Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: When calling getTxBySafeTxHash every status code is considered success #96

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Bug: When calling getTxBySafeTxHash every status code is considered success #96

merged 1 commit into from
Feb 16, 2021

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Feb 15, 2021

This PR:

  • Throws an error if returned status code is other than 200

@github-actions
Copy link
Contributor

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@mmv08 mmv08 merged commit a938d05 into development Feb 16, 2021
@mmv08 mmv08 deleted the bug/error-not-thrown-if-tx-not-found branch February 18, 2021 07:49
@mmv08 mmv08 mentioned this pull request Feb 18, 2021
Merged
mmv08 added a commit that referenced this pull request May 13, 2021
@mmv08
Merge pull request #96 from gnosis/bug/error-not-thrown-if-tx-not-found
6dad6eb 
Bug: When calling getTxBySafeTxHash every status code is considered success
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germartinez germartinez germartinez approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmv08 @germartinez